search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.5k stars 112 forks source link

ncneofetch displays weird banding artifacts on Terminal Resize - (Windows Command Prompt) #2417

Open guilt opened 2 years ago

guilt commented 2 years ago

Please include the following data:

Karthik@KVK-PC MINGW64 /c/Program Files (x86)/Notcurses
$ export | egrep 'LANG|LC_CTYPE|TERM'
declare -x TERM="xterm-256color"
3.0.0
Windows Command Prompt
WinVer = 22000.348 Windows 11 21H2
Wrap Text Output on Resize is **ON**

Screenshot 2021-12-02 040254

I noticed that for ncneofetch, when Wrap Text Output on Resize is on (default setting), there seems to be an artificial banding on some lines. Which persist when the terminal is brought back to original size. Not sure why the line isn't reset after that last character.

Other programs/demo are working/wrapping okay.

dankamongmen commented 2 years ago

ahhh yes i noticed this myself. it's windows terminal that's doing the unwelcome stretching. this happens after ncneofetch has already exited, right? in that case, there's not much it can do about it at that time...but perhaps we could do something when we originally write to keep this from happening? maybe some explicit background set or something. i'll look into it.

guilt commented 2 years ago

Issue spotted in Windows Terminal as well:

Windows Terminal
WinVer = 22000.348 Windows 11 21H2
Version = 1.11.2921.0

image

dankamongmen commented 2 years ago

yep, all those programs are frontends on the common WinPTY ConHost. you'll almost certainly see that in any windows terminal in which notcurses can run.

dankamongmen commented 2 years ago

ahh btw it looks like you also have a 3970X? it's nice to meet another man of taste =].

guilt commented 2 years ago

haha, yes I do! :)

dankamongmen commented 2 years ago

haha, yes I do! :)

https://nick-black.com/dankwiki/index.php/Schwarzgerat_II hell yeah, 3970X hot coder summer

dankamongmen commented 2 years ago

what i might do is file an issue over on the Microsoft Terminal project, asking what kind of workaround they suggest. it'd be wise to get their input on the entirety of their rewrapping/extending solution.

guilt commented 2 years ago

Nice, love your BOM for the build! Very detailed instructions indeed ... I have a 10Gig upgrade planned with multimode fiber soon. :)

Going to the issue, I'm not a 100% sure if we reset the terminal in the end of those few lines or not, maybe this should be confirmed by us before we reach out to the WT team. Currently this is just a noobie bug report, will post details when I gather a smaller testcase.

dankamongmen commented 2 years ago

to verify that kind of thing, i usually redirect the output to a file and then run it through xxd. redirection of stdout to a file is currently not working on windows, though =\ (#2409).

so let's see we've got that plane sitting by itself...yeah, we're not going to do any kind of color reset on the border. so that's definitely not yet explored. it may well resolve this, but i'd rather not have to issue a bunch of color controls if i can possibly avoid it.

j4james commented 2 years ago

FYI, this is a known issue in Windows Terminal. https://github.com/microsoft/terminal/issues/32