A mouse click can select a disabled item

[kascote]

After a mouse click and using ncmenu_mouse_selected, it returns the menu name without take into account the disabled state

Please include the following data:

• COLORTERM=24bit LANG=en_US.UTF-8 LESS_TERMCAP_mb=$'\C-[[01;31m' LESS_TERMCAP_md=$'\C-[[01;38;5;74m' LESS_TERMCAP_me=$'\C-[[0m' LESS_TERMCAP_se=$'\C-[[0m' LESS_TERMCAP_so=$'\C-[[38;5;246m' LESS_TERMCAP_ue=$'\C-[[0m' LESS_TERMCAP_us=$'\C-[[04;38;5;146m' TERM=xterm-kitty TERMINFO=/Applications/kitty.app/Contents/Resources/kitty/terminfo
• notcurses version 3.0.5
• terminal Kitty 0.24.1

[dankamongmen]

great find, thanks a lot for the report! i'll try to fix this up today for 3.0.6; it'll definitely be fixed by 3.1.0.

[dankamongmen]

alright, i'm looking into this using the menu PoC, and i'm unable to select any actual menu items with the mouse...hrm (xterm or kitty)

[dankamongmen]

i can select a top-level menu with the mouse, and it correctly does not select a disabled one...hrmm

[dankamongmen]

meanwhile, notcurses-demo seems to have no mouse capability....what the hell's going on?

[kascote]

the item is not selected, but the 'click' event came back from the get method, if you send the key event throw ncmenu_mouse_selected will return the item at that position, if the item is disabled must return null

[dankamongmen]

ok, i've got notcurses-demo fixed up for mouse menu events in master; we were throwing away any NCKEY_RELEASE. now let's see what elese is going on here.

[kascote]

for me this is not time sensitive or nothing.. prioritize as you will...

[dankamongmen]

nah, i'm looking into it now =] sorry it took even this long

[dankamongmen]

so it would seem that fixed notcurses-demo only for the notcurses-demo menu, not the help menu. so i suspect we have coordinate translation problems in play here, as well. probably need do a long hard look at how ncmenu handles mouse events, as i wrote this code back in the pre-1.0 days, and a great deal has changed since then.

[dankamongmen]

ok, looking at menu.c, we don't seem to handle subsection events there, just toplevel. That surprises me.

In that case, everyone must be supplying their own subsection handler...which yeah, makes sense, since it needs to run in our input context....right? Let's verify that...indeed, that's the whole point of ncmenu_mouse_selected().

ok, let me add that handler to the menu PoC, first off. it's already in notcurses-demo.

[dankamongmen]

i think we might possibly have introduced a regression when we moved to pixel-based mouseclicks? i've added it to menu, and successfully picked up Quit sometimes:

Y/X: 6/19
WIN Y/X: 6/19 dimy: 8
SELECTION: Quit

but other clicks that seemed to be there did not:

Y/X: 0/19
WIN Y/X: 0/19 dimy: 8
SECTION_X: 1
Y/X: 6/20
WIN Y/X: 6/20 dimy: 8
SELECTION: (null)
Y/X: 5/21
WIN Y/X: 5/21 dimy: 8
SELECTION: (null)
Y/X: 4/22

[dankamongmen]

ok so three problems noticed while adding this to menu:

• bottom menu clicks are off by one line
• clicks are only working through the text of the label, not through the breadth of the menu
• right-side menus only seem to accept clicks in the rightmost column

and finally, as @kascote originally noted, i don't think ncmenu_mouse_selected() prunes out disabled items.

there's quite a lot of brokenness here!

[dankamongmen]

heh see #2606, ugh

[dankamongmen]

ok the menu PoC now supports mouse events for menu items; i'm going to resolve the problems listed above

[dankamongmen]

menus should open to the first non-disabled item, also. if you disable the first item, it's still selected upon first opening.

[dankamongmen]

menus should open to the first non-disabled item, also. if you disable the first item, it's still selected upon first opening.

this is done

[dankamongmen]

ok we no longer return disabled items from ncmenu_mouse_selected(), which ought resolve the original point of this bug @kascote .

[dankamongmen]

ok the horizontal restrictions are due to use of section_x() in ncmenu_mouse_selection(), and indeed, we have this comment:

  // FIXME section_x() works only off the section header lengths, meaning that                                                      
  // if we click an item outside of those columns covered by the header, it will                                                    
  // read as a -1 from section_x(). we want to instead get the unrolled section,                                                    
  // find its boundaries, and verify that we are within them. 

[dankamongmen]

we ought just be able to use these, no?

  int xoff;               // column offset from beginning of menu bar                                                               
  int bodycols;           // column width of longest item    

[dankamongmen]

alright, we now accept ncmenu mouse clicks through the proper horizontal range

[dankamongmen]

alright, we now pick up the correct item for mouseclicks on bottom menus

[dankamongmen]

ok, all this crap seems to work now.