search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.48k stars 112 forks source link

No headers are installed with `USE_CXX=off` #2674

Closed kmarius closed 6 months ago

kmarius commented 2 years ago

I am running the commands as in the PKGBUILD but with -DUSE_CXX=off (and without the check, and the ffi, which both fail in this case), resulting in a package without headers.

kmarius commented 2 years ago

Looks like this https://github.com/dankamongmen/notcurses/blob/ab8590d7b3a7a3129a603e4235ff50eb2b0cfd9f/CMakeLists.txt#L577 is inside a large if(${USE_CXX}) block.

aghast commented 7 months ago

I had this same problem. I'm utterly incompetent at cmake, so I'm glad someone else reported it. I've been building the entire thing into an intermediate install directory and picking out the C-related parts that I care about as part of my do script.

I found that there is an endif() fairly close to that headers block, which I moved. The result does build, and it puts the C headers in the install dir without having to USE_CXX. I'd like to be able to say the library works, but I haven't been able to make that happen. (That was true even with the CXX stuff being built, so I think it's an unrelated item. I can't even get the blue house demo to work from the book online-- somehow stdin is always closed immediately.)

dankamongmen commented 6 months ago

this was fixed the other day in d88f40b836cd7e93c11e6d3e724b7b1eb43263c0, sorry it took so long for me to see this! thanks for the report!