search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.43k stars 113 forks source link

Fixes DECSDM interpretation for Contour. #2681

Closed christianparpart closed 1 year ago

christianparpart commented 1 year ago

We have that fixed since https://github.com/contour-terminal/contour/pull/431 (October 2021) - I don't see why we should if-guard here, either. So simply flipping the bit.

dankamongmen commented 1 year ago

looks good to me, thanks!

dankamongmen commented 1 year ago

FWIW, i normally guard this kind of thing with a version check. was the version that inverted DECSDM released in any distributions? it was in arch, right?

christianparpart commented 1 year ago

FWIW, i normally guard this kind of thing with a version check. was the version that inverted DECSDM released in any distributions? it was in arch, right?

Despite its functionality, I don't think Contour is as famous as being included downstream in any distribution just yet. We have an Arch AUR (but not under my control) and we deploy all the releases via Github release page plus recently Flathub, which makes updating super convenient. I was thinking of adding that guard (hence my statement on top) but I decided against it because the fix is in since so long already (11 months) and most users I am in contact with use master builds or are up to date with Github release page builds. :)

dankamongmen commented 1 year ago

if you're not worried about it, i'm not worried about it! hope you're doing well, friend

christianparpart commented 1 year ago

Yeah, thanks. And the more we go into the future the more likely I need to object on guards. Absolutely.

Have a look at the discussion I posted this afternoon. I am curious about your feedback.

On Sun, Sep 25, 2022, 4:01 PM nick black @.***> wrote:

if you're not worried about it, i'm not worried about it! hope you're doing well, friend

— Reply to this email directly, view it on GitHub https://github.com/dankamongmen/notcurses/pull/2681#issuecomment-1257202748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN3O7WFKFUEB3UFCJN7CLWABLLRANCNFSM6AAAAAAQVBS6ZI . You are receiving this because you authored the thread.Message ID: @.***>