Open C010UR opened 1 year ago
I enjoy nothing more than large C++ diagnostics! let me see if i can figure out what's going on; thanks for the report!
ooh and it's mingw, too. yes, i recall regular problems with OpenImageIO on the windows platform. ok, i'll need build back up some context to look into this. i think i only support ffmpeg on windows? maybe it's the other way around, though.
This make it build, but is it also separated to two libs on other platforms? https://packages.msys2.org/package/mingw-w64-ucrt-x86_64-openimageio?repo=ucrt64
/ucrt64/lib/libOpenImageIO.dll.a
/ucrt64/lib/libOpenImageIO_Util.dll.a
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5c8a23f26..77f6ed900 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -414,6 +414,7 @@ elseif(${USE_OIIO})
target_include_directories(notcurses PUBLIC "${OIIO_INCLUDE_DIRS}")
target_include_directories(notcurses-static PUBLIC "${OIIO_STATIC_INCLUDE_DIRS}")
target_link_libraries(notcurses PRIVATE OpenImageIO)
+target_link_libraries(notcurses PRIVATE OpenImageIO_Util)
target_link_libraries(notcurses-static PRIVATE ${OIIO_STATIC_LIBRARIES})
target_link_directories(notcurses PRIVATE ${OIIO_LIBRARY_DIRS})
target_link_directories(notcurses-static PRIVATE ${OIIO_STATIC_LIBRARY_DIRS})
oooh i don't know!
looks like yes on Linux. on those platforms, we get the library names from pkg-config
, which lists all necessary ones.
we would probably need a corresponding notcurses-static
line.
[schwarzgerat](1) $ pkg-config --libs OpenImageIO
-lOpenImageIO -lOpenImageIO_Util
[schwarzgerat](0) $
While trying to build libs using mingw, i get the error below. I used following cmake options:
USE_DOCTEST=off
USE_PANDOC=off
BUILD_EXECUTABLES=off
USE_MULTIMEDIA=oiio
. Using ffmpeg instead of OpenImageIO helps, but perfomance is bad and the demo breaks after the penguin scene.