Closed dankamongmen closed 4 months ago
taking a look at this now. it appears that we ought be using duration
rather than pkt_duration
. the latter is in units of time_base
. duration
is in the same units as pts
, which also appears to just be time_base
. so it looks like we can just replace pkt_duration
with duration
, and we're done? surely it's not that easy.
seems to work.
hrmm ffmpeg as recent as the one on our ubuntu builder only offers pkt_duration
argh
we now check for FF_API_PKT_DURATION
, and use pkt_duration
when it's defined. this still triggers a deprecation warning for some versions of ffmpeg, but it works on all versions (including new ones without pkt_duration
).
Attempting to build against recent (git checkout) ffmpeg hits: