search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.43k stars 113 forks source link

[workflows] delete ilmbase dependency in windows workflow #2700

Closed michaelsbradleyjr closed 1 year ago

michaelsbradleyjr commented 1 year ago

ilmbase is no longer offered:

michaelsbradleyjr commented 1 year ago

The windows build is still failing, but now it's owing to undefined reference errors related to oiio.

EDIT: seems to be same problem as reported in #2685. However, maybe this PR should still be merged since mingw-w64-ucrt-x86_64-ilmbase is no más.

michaelsbradleyjr commented 1 year ago

I tried switching back from Ninja to -G"MSYS Makefiles" and make to see if there would be any difference, but the errors were the same, so I killed that second commit in this PR branch.

michaelsbradleyjr commented 1 year ago

I found #2431 and it looked like the changes to switch to OpenImageIO's CMake support never got made, so I did that in 2bbbcdead2a906a1b522a93ab3010d1a06e99ab7.

But the build still fails with undefined reference errors, so I was going to kill that commit in this PR and open another one with that change and hopefully a fix for the errors too.

Anyway, apologies for the [wip] ... commit in the master branch; I should have switched the PR to draft before doing more experiments.

dankamongmen commented 1 year ago

it's no problem, but did we get things merged in the form you wanted?

michaelsbradleyjr commented 1 year ago

it's no problem, but did we get things merged in the form you wanted?

Yes, the changes merged were/are good to go.