dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.57k stars 112 forks source link

generating parse errors in kitty since at least 0.26.5 #2744

Open dankamongmen opened 9 months ago

dankamongmen commented 9 months ago

I ran notcurses-demo today for the first time in a minute, in kitty 0.26.5, and it generates the following:

[360 04:12:54.013882] [PARSE ERROR] Unknown terminfo property: RGB
[360 04:12:54.016195] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:12:54.016208] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:12:54.016771] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:12:54.016783] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:12:54.020368] [PARSE ERROR] Unknown CSI s sequence with start and end modifiers: '>' '' and 1 parameters
[360 04:15:33.625056] [PARSE ERROR] Unknown CSI s sequence with start and end modifiers: '>' '' and 1 parameters

this is all generated on startup; I do not see further output. notcurses-demo completes successfully.

the same result happens with kitty 0.31.0.

notcurses-info generates the same output:

[360 04:15:33.585651] [PARSE ERROR] Unknown terminfo property: RGB
[360 04:15:33.587542] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:15:33.587555] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:15:33.587782] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:15:33.587793] [PARSE ERROR] CSI code S has unsupported start modifier: S or end modifier: S
[360 04:15:33.594540] [PARSE ERROR] Unknown CSI s sequence with start and end modifiers: '>' '' and 1 parameters
[360 04:15:33.625056] [PARSE ERROR] Unknown CSI s sequence with start and end modifiers: '>' '' and 1 parameters
dankamongmen commented 7 months ago

still seeing this in 2024 with kitty 0.32.2. almost certainly our bug.

dankamongmen commented 7 months ago

alright. we send RGB (524742) as a terminal query (XTGETTCAP via IDQUERIES) in send_initial_queries() (unless minimal is set, which it usually is not). we don't want to wait until after we've got the terminal ID to send this (it's all pipelined). if kitty wants to print a warning about it, it can.

dankamongmen commented 7 months ago

"rgb" gets the same result, fwiw