search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.57k stars 112 forks source link

C++ wrapper: Plane::set_bg_rgb8 has a typo #2748

Closed zhiayang closed 8 months ago

zhiayang commented 8 months ago

notcurses 3.0.9.

this should be setting bg: https://github.com/dankamongmen/notcurses/blob/d0ae40415228871c68fc9cebe6a7f9ef0f476082/include/ncpp/Plane.hh#L904

but it seems like the c++ bindings haven't been updated in 2 years?

dankamongmen commented 8 months ago

well, they are only wrappers -- they shouldn't need changing unless there's an API change.

and you're absolutely right. thanks!

dankamongmen commented 8 months ago

I believe this to have been fixed in 051a1b8bb.