search

dankamongmen / notcurses

blingful character graphics/TUI library. definitely not curses.
https://nick-black.com/dankwiki/index.php/Notcurses
Other
3.4k stars 113 forks source link

Skipping prohibited unicode instead of erroring #2773

Open lokxii opened 3 months ago

lokxii commented 3 months ago

Currently printing string that contains prohibited unicode will result an error and stop printing (the error log pointed me to this line). Would it be better to skip the character and logwarn (or other level of logging) that the function skipped it?

dankamongmen commented 3 months ago

yeah, i've thought about this. the problem is that it's really hard to indicate to the caller that there were elided glyphs, or where they were. perhaps an option, though...?

lokxii commented 3 months ago

The problem with stopping at prohibited unicode is that I will have to sanitize the string myself before passing to notcurses, which would duplicate the utf8 checks.

Maybe an option would be good. Maybe you can also consider putting all the alignment and styling options in an option struct? This would be a breaking change tho. Just a random suggestion.

dankamongmen commented 3 months ago

yep, something like that. i'm pondering what to do. open to suggestions!

dankamongmen commented 3 months ago

i feel this would be a toplevel option rather than a per-call deal.