dankamongmen / panelreels

high-level objects built atop ncurses
https://nick-black.com/dankwiki/index.php/Outcurses
Apache License 2.0
8 stars 1 forks source link

FindCurses.cmake doesn't seem to work on Arch for ncursesw #2

Closed dankamongmen closed 4 years ago

dankamongmen commented 5 years ago

In CMakeLists.txt, we have:

set(CURSES_NEED_WIDE TRUE)
set(CURSES_NEED_NCURSES TRUE)
find_package(Curses REQUIRED)

this doesn't appear to work on Arch, which complains that it can't find the headers. It works fine if I remove the CURSES_NEED_WIDE definition, and indeed properly links to libncursesw.so. On Debian, if I remove the CURSES_NEED_WIDE definition, we get libncurses.so without widechar support, and things break at linktime.

dankamongmen commented 4 years ago

https://gitlab.kitware.com/cmake/cmake/merge_requests/3845 filed upstream. This appears to fix the problem. If it gets merged, we'll rely on that; if not, we'll work out a workaround.

dankamongmen commented 4 years ago

Yay, my patch has been accepted for CMake 3.16.0, scheduled for cutting 2019-10-01. Awesome!