search

dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
143 stars 42 forks source link

CRAN release plans #1373

Closed dankelley closed 6 years ago

dankelley commented 6 years ago

PRESCRIPT: I will be editing this comment in-place, to avoid a lot of email notifications that might annoy the co-developers.

I got an email from Kurt Hornik about a problem with the CRAN code, for R-devel (the upcoming R version), in which he was kind enough to suggest a patch. (The error is shown at https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/oce-00check.html.) He requested a quick resubmission of oce, so I merged "develop" into master, and started working on testing that.

I found a problem with an http: in a doc that gave a warning, so I switched to https: (yielding "master" branch commit 2f1616b2c9f928a5ecbc9266a857fc5fe885cbfb ) and the warning went away.

Then, as part of the submission process, a spell checker found some problems. I figure I might as well crank some tunes and fix them, and the result is "master" branch commit c5a64c64a1b6f35c38f80d98c5a0e0e16401b0ac and all tests below are with respect to that.

TESTS

FILES

SUBMISSION

dankelley commented 6 years ago

Submitted. The email back from CRAN is as follows.

[This was generated from CRAN.R-project.org/submit.html]

The following package was uploaded to CRAN:

Package Information: Package: oce Version: 0.9-23 Title: Analysis of Oceanographic Data Author(s): Dan Kelley [aut, cre], Clark Richards [aut], Chantelle Layton [ctb] (curl() coauthor), British Geological Survey [ctb, cph] (magnetic-field subroutine) Maintainer: Dan Kelley Dan.Kelley@Dal.Ca Depends: R (>= 2.15), utils, methods, gsw, testthat Suggests: ocedata, foreign, ncdf4, tiff, akima, RSQLite, DBI, rgdal (>= 1.1-9), R.utils, knitr, rmarkdown, marmap, lubridate Description: Supports the analysis of Oceanographic data, including 'ADCP' measurements, measurements made with 'argo' floats, 'CTD' measurements, sectional data, sea-level time series, coastline and topographic data, etc. Provides specialized functions for calculating seawater properties such as potential temperature in either the 'UNESCO' or 'TEOS-10' equation of state. Produces graphical displays that conform to the conventions of the Oceanographic literature. License: GPL (>= 2)

The maintainer confirms that he or she has read and agrees to the CRAN policies.

Submitter's comment: ## Test environments

Comment: I've tried the build_win(version="R-devel") a few times, without success, but this seems not to be a difficulty owing to oce. Also, the rhub::check_for_cran() and rhub::check_with_rdevel() results make me somewhat sanguine about the possibilility of clean CRAN builds.

R CMD check results

0 errors | 0 warnings | 1 note

Reverse

dependencies

devtools::revdep_check() reports as follows

Comment: the error details are as follows

  1. dendroTools fails (as noted on its CRAN check page) because it relies on

    RWeka, which is unavailable.

  2. seewave fails (as noted on its CRAN check page) because it relies on

    "seawave", which is unavailable.

and so I propose that 'oce' be considered to have passed the dependence checks, since the listed errors are unrelated to it.

This release is partly motivated by a POSIXlt-related error reported in the R-devel build, which Kurt Hornik kindly pointed out in an email to Dan Kelley, dated 2018-01-28. I apologize for not monitoring the CRAN check website as often as I should, to notice new errors.

=================================================

Original content of DESCRIPTION file:

Package: oce Type: Package Title: Analysis of Oceanographic Data Version: 0.9-23 Authors@R: c(person(given="Dan", family="Kelley", email="Dan.Kelley@Dal.Ca", role=c("aut", "cre")), person(given="Clark", family="Richards", email="clark.richards@gmail.com", role=c("aut")), person(given="Chantelle", family="Layton", email="chantelle.layton@dal.ca", role=c("ctb"), comment="curl() coauthor"), person(given="British Geological Survey", role=c("ctb","cph"), comment="magnetic-field subroutine")) Maintainer: Dan Kelley Dan.Kelley@Dal.Ca Depends: R (>= 2.15), utils, methods, gsw, testthat Suggests: ocedata, foreign, ncdf4, tiff, akima, RSQLite, DBI, rgdal (>= 1.1-9), R.utils, knitr, rmarkdown, marmap, lubridate BugReports: https://github.com/dankelley/oce/issues Description: Supports the analysis of Oceanographic data, including 'ADCP' measurements, measurements made with 'argo' floats, 'CTD' measurements, sectional data, sea-level time series, coastline and topographic data, etc. Provides specialized functions for calculating seawater properties such as potential temperature in either the 'UNESCO' or 'TEOS-10' equation of state. Produces graphical displays that conform to the conventions of the Oceanographic literature. License: GPL (>= 2) Encoding: UTF-8 URL: https://dankelley.github.io/oce LazyData: false RoxygenNote: 6.0.1 BuildVignettes: true VignetteBuilder: knitr NeedsCompilation: yes Packaged: 2018-01-28 19:14:15 UTC; kelley Author: Dan Kelley [aut, cre], Clark Richards [aut], Chantelle Layton [ctb] (curl() coauthor), British Geological Survey [ctb, cph] (magnetic-field subroutine)

dankelley commented 6 years ago

Closing now, since it was submitted. I may reopen this as a convenient place to save a diary of any followup changes that are required.