dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
143 stars 42 forks source link

SBE name 'sbox0Mm/Kg' not recognized #1438

Closed dankelley closed 6 years ago

dankelley commented 6 years ago

e.g.

> d<-read.oce("st01_CTD01_20180816_bb_align_filter_cellTM_binavg.cnv")
Warning message:
In cnvName2oceName(lines[nameLines[iline]], columns, debug = debug -  :
  unrecognized SBE name 'sbox0Mm/Kg'; consider using 'columns' to define this name
dankelley commented 6 years ago

Hm, I see why we don't handle it. This is not named in the SBE docs that I have available (https://www.dropbox.com/s/zpcmz0rka4vadyh/SBEDataProcessing_7.26.7.pdf?dl=0). I'll see if there are new docs. My policy is to focus on documented things, because then I can copy into the oce documentation whatever details are in the SBE documentation Perhaps this 'sbox0Mm/Kg' is actually the same as the 'sbeox0Mm/Kg' that is documented (but not handled yet because I never saw it before).

PS. what the heck is Seabird doing, using 'Mm' for "umol"? Surely they know that "M" means something...

dankelley commented 6 years ago

Hm, ?read.ctd.sbe says as below, but the link no longer works. Oh well, it's been 5 weeks, cannot blame a company for altering it's webpage (ug)

  1. A SBE data processing manual is at http://www.seabird.com/document/sbe-data-processing-manual; as of 2018-07-05, the latest version was named SBEDataProcessing_7.26.4.pdf and had release date 12/08/2017.
dankelley commented 6 years ago

Update: I still cannot find the "SBE processing manual" on the Seabird website. It's referred to in their documents, but their own links are broken. I may check again once a month or so.

As an update, I found at http://www.odb.ntu.edu.tw/Thermosalinograph/instrument/SBEDataProcessing.pdf an old version. (Lots of investigators put their manuals online, actually, and a search will likely uncover some that are more recent than this one.)

Below is a snapshot that shows the file contents, and a line in the manual linked to in the previous paragraph. It really looks as though Seabird may be using two names for the same thing, but, again, I am very reluctant to make oce reliant on such an assumption, for the whole point of seabird-related oce development over the past couple of years has been to tie the oce code (and its documentation) precisely with the Seabird documentation.

screen shot 2018-08-25 at 10 59 26 am
dankelley commented 6 years ago

The link below agrees (by means of a comment) with my hypothesis of the meaning of this column. Of course, this is just code, written by someone like me who is trying to find a path forward. What I may do is to recognize it, but to issue a warning, just in case.

https://github.com/NOAA-PMEL/AtSeaPrograms/blob/7b1926203244375361d7da6245165582b2b61ecd/OnCruiseRoutines/EPICNetCDF/SBE_Epiclibrary.py#L133

dankelley commented 6 years ago

In the "develop" branch, commit 213cbeca58aa5f443354b4bb3a19da14800977d7 (click that link to see code changes), I now permit e.g. sbox0Mm/Kg as a synonym for sbeox0Mm/Kg. However, since I have not seen this synonym documented in SBE documents, I issue a warning when such a label is encountered. If I ever get updated SBE documents that describe e.g. sbox0Mm/Kg precisely, I may revise the code. (Perhaps the instrument type might be called "SBE 43new" or something ... who knows?)

In the meantime, I am closing this issue, since it has been addressed.