search

dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
143 stars 42 forks source link

seabird CTD (cnv) files should have better names for time columns #1458

Closed dankelley closed 6 years ago

dankelley commented 6 years ago

In working on #1457 I realized that seabird has a lot of time names. Previous to this, I was naming several different things as "time", but now I realize that doing this will confuse users. My new decision is to name them as in the .cnv file, because that will not surprise users.

PS. I think the seabird docs may be a bit messed up. They say that timeJ is the time, in days, since the first item in the scan. But it is surely not that, in the data files I'm looking at for #1457.

dankelley commented 6 years ago

Done in "develop" branch, commit c27acc13159cdcb517f86ba8dec7385937d492dd

richardsc commented 6 years ago

I've run into these times recently too ... I'll see if I can remember which file I saw it for and will try the new version.