dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
145 stars 42 forks source link

Can the nortek aquadopp "orientation" field change during a deployment? #1761

Open richardsc opened 3 years ago

richardsc commented 3 years ago

Following on from https://github.com/dankelley/oce/issues/1758#issuecomment-745566119

Oh, and I see the "orientation" field IS there, it's just been renamed to be orientation, rather than configTiltSensorOrientation ...

    if (missing(orientation)) {
        orientation <- header$head$configTiltSensorOrientation # FIXME: is there a 'header$head'?
    } else {
        orientation <- match.arg(orientation, c("sideward", "upward", "downward"))
    }

One concern I have about this (which was an issue with RDI instruments, I believe), is that we are treating this field as a constant for the entire file, whereas it may actually vary depending on how the orientation changes. For example, if the instrument was lying on its side on deck before deployment, it might register that as "downward" even if it ends up deployed in an "upward" position. I'd better open a separate issue for this (and debug by checking the instrument logs, which I'm waiting for from our field group).

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next week (or the 'pinned' label is applied), this issue will be closed automatically in a week.

richardsc commented 3 years ago

Slow down stale bot -- it's the holidays!

dankelley commented 3 years ago

I just doubled both time criteria.

dankelley commented 3 years ago

A reminder: I'll need a sample file. (To prevent concern over missing-mail problems, please note that I'll email back when you send it.)

richardsc commented 3 years ago

Sent.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week.

richardsc commented 3 years ago

Removing the stale label, as I am waiting for @dankelley to have a look at the sample file that I sent. There isn't a big rush for this, but it probably shoudn't just disappear.

dankelley commented 3 years ago

I imagine you knew I was going to ask this, but can you resend the sample file? I don't track emails well (by which I mean that I delete old emails aggressively), and unless I put files into a subdirectory in the oce-issues repo, I don't know where to look. I tried as below (guessing a filename from #1758) but got no hits.

find ~ -name 205413.AQD -print
richardsc commented 3 years ago

Sent (again 😄 ). Filename is aqd9330.aqd.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week. Please note that this is not a reflection on the quality or importance of the issue, but merely a reminder of the march of time. A simple comment is all it takes to keep this issue from being closed automatically, two weeks from now.

dankelley commented 3 years ago

I'm commenting to keep this issue alive. I keep forgetting about it, sorry.

stale[bot] commented 2 years ago

An automated message from the stale bot -- this issue has been marked as stale because no comments have been made in 30 days. The goal of this action is to remind reporter and developers alike that progress seems to have stalled. Please note that the issue will be automatically closed 30 days from now, unless a comment is made, or the pinned label is applied. Thank you.