dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
142 stars 42 forks source link

remove ftp: in docs #1809

Closed dankelley closed 3 years ago

dankelley commented 3 years ago

As per instructions below, from Brian Ripley, we need to stop using ftp: in the docs and vignettes. Luckily, this doesn't seem to be a "change or your package will be withdrawn from CRAN" situation.

CAUTION: The Sender of this email is not from within Dalhousie. that is ActiveDriverWGS AncestryMapper BDgraph BayesSUR BioMedR CHNOSZ CVR CePa ClusteredMutations D3GB DAAG DDPNA EPT EcoHydRology FluMoDL GSDA GenomicTools.fileHandler HGNChelper HTLR HelpersMG HiddenMarkov HistDAWass ICAMS IFP LDheatmap LogisticDx Matrix MetFns POFIBGE PlasmaMutationDetector ProTrackR PtProcess RFLPtools RGtk2 RSIP RWsearch RapidoPGS Rgb SAScii SEERaBomb Stat2Data TSA UsingR VFS WaveletComp ade4 agridat anesrake ape aphid astrolibR bayesGARCH berryFunctions biocompute biomartr bomrang climate compendiumdb countyweather crn curl dLagM datamart dawai dcGOR decoder dplR earthtide emIRT esmisc future gap genoPlotR ggTimeSeries ggsci gms gsloid hoardeR hsdar httk insect isdparser kernlab linprog mangoTraining manhattanly mapmisc mclust metaMix metacoder meteo mlbench mlr3proba oc oce oompaData openintro palinsol palr partitionMap pcaPP pegas phreeqc plot3D polyRAD protr pscl qdapRegex raster rasterVis rattle rdwd read.dbc remap reproducible rnoaa satellite satin scopr seqinr sigminer smoothHR spam spatialEco spgs splancs splusTimeDate steadyICA stellaR stevedata survey sysid taxizedb taxonomizr textclean tfarima ursa usa varrank wflo wnominate worldmet xfun yuima Browsers are increasingly not supporting ftp:// sites -- AFAWK Chrome and Firefox have removed support already this year and Safari and (non-legacy) Edge never had support. Please review your usage and change to https:// or http:// if possible (possibly using another site). It is not anticipated that R will remove facilities for downloading from ftp:// sites in the near future but they will become increasingly untested and secure sites (https:// since ftps:// is almost unused) are much preferred. -- Brian D. Ripley, ripley@stats.ox.ac.uk Emeritus Professor of Applied Statistics, University of Oxford
dankelley commented 3 years ago
➜  oce git:(develop) git grep "^#'.*ftp:"
➜  oce git:(develop)
R/amsr.R:655:#' `ftp://ftp.ssmi.com/amsr2/bmaps_v07.2/` and login as "guest",
R/argo.R:53:#'\url{ftp://ftp.ifremer.fr/ifremer/argo/dac/bodc/6900388/6900388_prof.nc}
R/argo.R:1100:#' \code{ftp://usgodae.org/pub/outgoing/argo/geo/} being an example.
R/sun.R:33:#' ftp://climate1.gsfc.nasa.gov/wiscombe/Solar_Rad/SunAngles/sunae.f on
dankelley commented 3 years ago

I think I've done this in "develop" commit 40e7799769c9a8d21531d5824a1b65ab6acda360. At any rate

➜  oce git:(develop) grep -n "^#'.*ftp:"

now produces no output, which indicates that we no longer have any Roxygen lines containing the string ftp:.

If I learn more about how they detect the use of ftp URLs, I'll reopen this and add more fixes.