search

dankelley / oce

R package for oceanographic processing
http://dankelley.github.io/oce/
GNU General Public License v3.0
143 stars 42 forks source link

drawIsopycnals() should permit stating the isopycnal #385

Closed dankelley closed 10 years ago

dankelley commented 10 years ago

And I'm also not sure I like rhoLevels as an arg; maybe this should mimic contour(), with arguments nlevels and levels. I don't imagine too many people are calling this function directly so it should not be too much of a problem altering the argument list (probably with rhoLevels getting a deprecation warning).

PS. want this to demonstrate setup of a cabelling experiment.

richardsc commented 10 years ago

I agree you should be able to specify which rhoLevel (or levels) you want to plot.

I use the function quite a bit, for plotting over fancy TS-type plots that were not generated with plotTS() (e.g. the 2D histograms in TS space), but I don't think I've ever altered the default plot levels so this should break anything I have (a quick grep -r drawIso . confirms this).

dankelley commented 10 years ago

I altered the arg list. Now one gives nlevels or levels, a bit like how one does with contour(). Also there is a new arg for the number of digits to show (since for my application there were 16 digits!).