need to update a few things

[dankelley]

When I build, I get as follows. The first doesn't matter, but the second does, so I'll address that, and anything else I get with a full local build-check operation.

ℹ Updating ocencdf documentation
Setting `RoxygenNote` to "7.3.1"
ℹ Loading ocencdf
✖ ocencdf.R:44: `@docType "package"` is
  deprecated.
ℹ Please document "_PACKAGE" instead.

[dankelley]

Above fixed. Not pushed to GH yet because I also see the following spelling errors. (I'm not saying we want to submit to CRAN, but if we do, then there must not be any errors from this command.)

> devtools::spell_check()
DESCRIPTION does not contain 'Language' field. Defaulting to 'en-US'.
  WORD           FOUND IN
ADCP           NEWS.md:9
               README.md:1
               introduction.Rmd:76
adp            adp2ncdf.Rd:5,71,77
               ncdf2adp.Rd:5,28,50,56
               ocencdf-package.Rd:38
               built_in_vartables.Rmd:33
argo           getVarInfo.Rd:31
               ncdfNames2oceNames.Rd:11
               built_in_vartables.Rmd:68
ctd            ctd2ncdf.Rd:5
               ncdf2ctd.Rd:5,24
               ncdf2oce.Rd:31
               introduction.Rmd:76,94,132
CTD            adp2ncdf.Rd:18
               adv2ncdf.Rd:18
               ctd2ncdf.Rd:19,76,82
               ncdf2ctd.Rd:27,33
               oce2ncdf.Rd:20
               NEWS.md:14
               README.md:1
               introduction.Rmd:55,107
flavour        getVarInfo.Rd:40
focussed       README.md:1
               introduction.Rmd:76
Hydographic    introduction.Rmd:94
Hydrographic   built_in_vartables.Rmd:87
json           ocencdf-package.Rd:24
JSON           adp2ncdf.Rd:39
               adv2ncdf.Rd:39
               json2metadata.Rd:5
               metadata2json.Rd:5,12,17,22,34,37
               ocencdf-package.Rd:23,25,27,32,40
               NEWS.md:4
netCDF         adp2ncdf.Rd:20,22,23
               adv2ncdf.Rd:20,22,23
               ctd2ncdf.Rd:21,23,24
               oce2ncdf.Rd:22,24,25
NetCDF         adp2ncdf.Rd:5,32
               adv2ncdf.Rd:5,32
               ctd2ncdf.Rd:5,32,38,42
               getVarInfo.Rd:31,32,40
               ncdf2adp.Rd:5,26
               ncdf2adv.Rd:5,26
               ncdf2ctd.Rd:5,24
               ncdf2oce.Rd:5,24,26,27,31
               ncdfNames2oceNames.Rd:5,22
               oce2ncdf.Rd:5
               oceNames2ncdfNames.Rd:5,22
               ocencdf-package.Rd:7,10,15,16,20,22
               read.varTable.Rd:19,24
               title:1
               description:1
               README.md:1
               introduction.Rmd:46,51,55,66,68,89,122,128
oce            adp2ncdf.Rd:10
               adv2ncdf.Rd:10
               ctd2ncdf.Rd:10,38
               getVarInfo.Rd:21
               json2metadata.Rd:5
               metadata2json.Rd:5,10
               ncdf2oce.Rd:5,30
               ncdfNames2oceNames.Rd:5,10,22
               oce2ncdf.Rd:5,10
               oceNames2ncdfNames.Rd:5,10,22
               ocencdf-package.Rd:7,10,19,28,30,33
               description:1
               README.md:1
               introduction.Rmd:46,51,55,68,76,94,109
Oce            metadata2json.Rd:33,35
               ocencdf-package.Rd:12
               title:1
               introduction.Rmd:94
ORCID          ocencdf-package.Rd:52
POSIXct        metadata2json.Rd:38
priori         introduction.Rmd:63
RDI            metadata2json.Rd:36
               ocencdf-package.Rd:38
Teledyne       metadata2json.Rd:36
               ocencdf-package.Rd:38
transferral    introduction.Rmd:68
varTable       getVarInfo.Rd:5
               ncdfNames2oceNames.Rd:11
               introduction.Rmd:128
varTables      NEWS.md:10
               built_in_vartables.Rmd:2
               introduction.Rmd:94
whp            read.varTable.Rd:40
YAML           read.varTable.Rd:23
               NEWS.md:4
               built_in_vartables.Rmd:25
               introduction.Rmd:94
yhp            built_in_vartables.Rmd:85
yml            read.varTable.Rd:40

[dankelley]

I've addressed the above in "develop" commit 813e7355922b606c2b281cad5c5567536d6e9da5. I am keeping this issue open until I see that all remote checks were OK. I'll check back on the status in an hour. Meantime, here is a list of changes in addition to what is listed above:

• fix spelling errors
• add CR as contributor
• bump version number
• run codemeta
• rebuild website
• add check_package.R, which checks spelling, URLs, and also submits remote checks on 4 different platforms

[dankelley]

@richardsc -- I notice that we get an error now in a remote build (but not locally). I am waiting for 3 other remote tests. We'll see if they all fail. My guess is that we are just not permitted to create new files according to CRAN rules. We can avoid that by using a temporary name for the output file, or by just not including those lines of the examples.

> # Transfer to NetCDF and back to see if results make sense
> oce2ncdf(adp, ncfile="adp.nc")
Error in R_nc4_create: Permission denied (creation mode was 4096)
Error in nc_create(ncfile, vars, force_v4 = force_v4) : 
  Error in nc_create!
Calls: oce2ncdf -> adp2ncdf -> nc_create

See temporary website https://win-builder.r-project.org/5IKYAHxXuPLK/00check.log

[dankelley]

Yes, it's failing on another now. I have a fix that I'm testing now. It will be another half hour to know if it works but I'm doing other stuff so no big deal.

[richardsc]

Thanks!

Re: spelling errors -- I noticed this one in the vignette, and was confused for a while at what it was supposed to be:

yhp            built_in_vartables.Rmd:85

is that just a typo for "whp" i.e. World Hydrographic Program?

[dankelley]

Sorry, my GH notifications were turned off so I never noticed @richardsc's comment from a month ago. I've just cleared up the yhp (whp, of course) typo. I'm closing this now, since I've done the things I had listed. (Also, I had a pretty bad title -- it is not something anybody could search, which is the whole point of titles.)