No warning is shown when adding a new URL fails

dankito / DeepThought

A knowledge management application for Android and Java

4 stars 1 forks source link

No warning is shown when adding a new URL fails #4

Open b3nk4n opened 6 years ago

b3nk4n commented 6 years ago

Steps to reproduce

Start edding a new URL
Enter zdf.de
Press add
Nothing happens (it is not clear whether the URL is wrong, or there might be another error, such as no internet?)

Expected behavior

I would expect a message or something similar that indicates that the URL is no valid RSS feed. An alternative might be to indicate the "search" using a progess bar/ring. So that it is at least clear that the app tried to find something :)

b3nk4n commented 6 years ago

I just realized that there is a modal dialog showing:

"Kein RSS oder Atom Feed gefunden für URL http://www.zdf.de", but:

the dialog(s) were about 30 sec too late!
the dialog was only visible after pausing and resuming the app
because I pressed "add" 10 times, 10 dialogs have been created on top of each other

dankito commented 6 years ago

So if i read your second comment right it hasn't been an issue that the application didn't recognize that there was no feed for that address, but that the modal dialog hasn't been shown correctly. Eventually it got hidden by 'Enter url' dialog (maybe wrong z-order).

According to this resource this may happens sometimes: https://stackoverflow.com/questions/44643366/alertdialog-is-hidden-by-activity. To resolve this one has to supply the application context (used the current activity) and add a special flag. Going to try that one ...

dankito commented 6 years ago

Ok, this was not the best tipp Stackoverflow could give:

Using applicationContext instead of activity results in an application crash with 'Unable to add window -- token null is not for an application' exception
Using the special window flags results in an application crash due to insufficient permission to use that flag g. Will have to investigate further to shed some light on this.