Arabic text support - Githubissues

knjl34 commented 5 years ago

hi,

for Link text change? How to proceed with arabic support ?

dankito commented 5 years ago

Hi knjl34,

sorry, I don't get you. What do you mean, what is the concrete issue?

Isn't anything working with HTML \ elements, is there a problem with the Insert Link dialog, ...?

Could you provide a more specific description or a screenshot that shows the issue?

knjl34 commented 5 years ago

Hi knjl34,

sorry, I don't get you. What do you mean, what is the concrete issue?

Isn't anything working with HTML elements, is there a problem with the Insert Link dialog, ...?

Could you provide a more specific description or a screenshot that shows the issue?

Isn't anything working with HTML elements, is there a problem with the Insert Link dialog, ...? === yes in Arabic link dialog display in English -- how to do that in Arabic. there is no res. in ar. so please add that in Arabic or allow me to do that.

please refer image: https://ibb.co/8ddbfPc

thanks in advance.

dankito commented 5 years ago

Ah ok, then of course I can help you.

As I only speak a few words Arabic, could you provide these translations for me?

Go to the file RichTextEditorAndroid/src/main/res/strings.xml .

Copy that to a folder named "values-ar" and provide translations for all keys that you need (if you like to I would be glad if you provide a translation for all of the keys).

If you like to allow your users to browse for images to insert, you would also have to provide translations for this file https://github.com/dankito/AndroidFileChooserDialog/blob/master/FileChooserDialog/src/main/res/values/strings.xml.

knjl34 commented 5 years ago

i have changed that now one more help you can do is in link dialog whenever i have pressed ok after adding link please append this "http://" so in textview it will be clickable.

like i have added google.com then convert it to be http://google.com so in textview it will auto click and goes to browser.

thanx in advance.

knjl34 commented 5 years ago

https://ibb.co/8ddbfPc

knjl34 commented 5 years ago

Ah ok, then of course I can help you.

As I only speak a few words Arabic, could you provide these translations for me?

Go to the file RichTextEditorAndroid/src/main/res/strings.xml .

Copy that to a folder named "values-ar" and provide translations for all keys that you need (if you like to I would be glad if you provide a translation for all of the keys).

If you like to allow your users to browse for images to insert, you would also have to provide translations for this file https://github.com/dankito/AndroidFileChooserDialog/blob/master/FileChooserDialog/src/main/res/values/strings.xml.

Have you done commit changes ?

dankito commented 5 years ago

Which commit do you mean?

As I said, my Arabic is almost not existing, so you would have to provide these files / translations for me.

If you provide them to me, I'll be glad to commit and publish them.

knjl34 commented 5 years ago

hi

رابط الموقع عرض النص مسار الصورة أو عنوان الويب … نص بديل (اختياري) تحميل على الجهاز لحفظ الصورة خارج (غير مرئي) إذن مجلد التطبيق للكتابة إلى وحدة التخزين الخارجية. اختيار لون النص حدد لون خلفية النص Heading 1 ]]> Heading 2 ]]> Heading 3 ]]> Heading 4 ]]> Heading 5 ]]> Heading 6 ]]> Text body

]]> Preformat ]]> Quote ]]> Teeny ]]> Very small ]]> Small ]]> Large ]]> Very large ]]> Huge ]]> %d of %d

this are the string please add and commit it we need it in emergency basis and in link section please add https:// when in user enter any link so that link became clickable in textview.

thanks for the update and kind support.

knjl34 commented 5 years ago

hey,

whenever you are doing changes then please do this in link section please add "https://" when in user enter any link so that link became clickable in text view.

Thanks & Regards, KInjal Patel, S/w Engineer.

dankito commented 5 years ago

Hey,

sorry, oversaw completely the 'http://' part.

Thought about it. I find it problematic for several reasons:

Add 'http://' (your first proposal) or 'https://' (your second proposal)? RichTextEditor cannot know if for a specific url http or https is correct.
Also add 'www.'? Most websites need that as well.
I wouldn't silently add anything to the value the user entered. Some users would like to have exactly the same value as they entered and would be really angry about this dark magic (as there's no way to remove 'http://' again from link, RichTextEditor would insert it on each edit again).

So what do you think about that the default value entered is 'https://www.' and everything is selected by default, so that if the user doesn't like it, she/he can remove it with one click on Del button on keyboard?

Screenshot_20190923-172127

If you think it's OK, I can release the new version in approximately an hour.

Your Arabic translation is highly appreciated and will be committed in a few minutes (on branch release/2.0.x).

And no more "we need it in emergency basis" or similar please. RichTextEditor is a non commercial open source software and I develop it entirely in my spare time, so I cannot always find to do something. There's also a reason why you don't pay anything for it.

knjl34 commented 5 years ago

hey ,

Yes that's also i can understand but we can archive it by condition basis like if itsn't contain then add else ignore ,

as i have already implemented and checked this type of scenario so its really help full for developer purpose of the and its better to add that condition basis and in textview automatically it will be clickable so please do it in condition basis.

dankito commented 5 years ago

Sorry, what do you mean with "condition basis"?

The option to enter it by default in TextView and user can delete it or the dark magic option by silently adding 'http://'?

For the second option, a way to do this only in your application, would be to override InsertLinkCommand and there the method executeCommand():

override fun executeCommand(executor: JavaScriptExecutorBase) {
    selectLinkToInsert { url, title ->
        executor.insertLink(url, title)
    }
}

Instead of calling executor.insertLink(url, title) directly implement you custom code there.

knjl34 commented 5 years ago

hey ,

Yes that's also i can understand but we can archive it by condition basis like if itsn't contain then add else ignore ,

as i have already implemented and checked this type of scenario so its really help full for developer purpose of the and its better to add that condition basis and in textview automatically it will be clickable so please do it in condition basis.

I

this one will be fine so you can proceed for release !!

dankito commented 5 years ago

Released version 2.0.12 about an hour ago, but still cannot see it on Maven Central (Sonatype gave me some errors when uploading it, but should have worked).

Can you already see 2.0.12?

dankito commented 5 years ago

Now it's synchronized.

Check it out if it works for you and give me a feedback if not. (Otherwise feel free to close this issue.)

knjl34 commented 5 years ago

hey,

its working perfect but for that dialog where http://www. are display in that dialog layout in ar, should be rtl, right now its display lrt,

rest of the things are working perfect Kudos,

Thanks.

dankito / RichTextEditor

Arabic text support #29