Inside package.json, why "mocha" is in dependencies, not devDependencies?

dankogai / js-base64

Base64 implementation for JavaScript

BSD 3-Clause "New" or "Revised" License

4.27k stars 1.33k forks source link

Inside package.json, why "mocha" is in dependencies, not devDependencies? #149

Closed xiaoyuze88 closed 3 years ago

xiaoyuze88 commented 3 years ago

Put "mocha" in dependencies made some issues when we build our production version of our project, should "mocha" be place in devDependencies?

dankogai commented 3 years ago

You are right. I THOUGHT it was in devDependencies but it is in dependencies which should be empty since js-base64 does not depend on any other modules. It is fixed in e4362c7c5164ae4058c2e11a71708809f6d819ba.