dankogai / js-base64

Base64 implementation for JavaScript
BSD 3-Clause "New" or "Revised" License
4.27k stars 1.33k forks source link

fix dual package hazard #173

Closed jcbhmr closed 9 months ago

jcbhmr commented 9 months ago

use cjs as the source of truth and just re-export it

fix #168

dankogai commented 9 months ago

Sorry I cannot accept this. I already explained why https://github.com/dankogai/js-base64/pull/172 is good enough in:

https://github.com/dankogai/js-base64/issues/168#issuecomment-1901743134

In addition to that, the use of default export is too harmful.

https://www.google.com/search?q=avoid+default+export