search

dankrapek / bwui-capstone-placeholder

0 stars 0 forks source link

Summary #1

Open Tzuridis opened 5 years ago

Tzuridis commented 5 years ago

Rubric Score

Criteria 1: All Pages are Included

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You included all required pages for the project. Great work!

Criteria 2: CSS

  • Score Level: 3/4 (Meets Expectations)
  • Comment(s): You did a good job with your CSS styling. The styling is consistent across all of your pages, the only suggestion I have is for you to do a little bit more to your footer section. Great work.

Criteria 3: Use of CSS Selectors and Syntax

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Your used all appropriate selectors and syntax in your CSS.

Criteria 4: CSS Grid

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Throughout your website, you had good use of CSS Grid for styling the layout. Nice job!

Criteria 5: Branding

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): The branding of your web pages is good. It uses a minimal color palette to accentuate the experience without overpowering it. Your use of imagery around the pages is nice as well and provides a good break from just plain text. Additionally, your typography is good. Nice job!

Criteria 6: Typography

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): The typography you used in different situations was pretty good. You did a good job of distinguishing headings from body text, creating a visually distinct hierarchy that a user could follow. Nice job!

Criteria 7: Page Linking

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): The functionality of your page links is great. The navigation from page to page and the breadcrumbs links work perfectly. Good job!

Criteria 8: Accessibility

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): The pages you created have great accessibility for a screen reader. You used semantic HTML5 elements and aria roles and labels appropriately for the different types of content, which is great. Nice job.

Criteria 9: Responsive Design

  • Score Level: 3/4 (Meets Expectations)
  • Comment(s): Your pages are responsive and resize based on different screen sizes but the footer section does not resize correctly. That is for a really small screen but it is something you can take a look at. Nice work!

Overall Score: 34/36

Overall, you did a great job with this project. Your formatting was great, making all of code easy to read. You demonstrated good knowledge of both HTML and CSS - using semantic elements appropriately in the HTML and choosing appropriate selectors. Your design and branding was minimal and consistent throughout. You made good choices when it came to typography as well. One area of improvement would be to make those changes to the footer for styling and responsive design. Great work!

dankrapek commented 5 years ago

Thanks for the super-quick review!