danleh / wasabi

A dynamic analysis framework for WebAssembly programs.
http://wasabi.software-lab.org
MIT License
366 stars 47 forks source link

Replace Long.js conversion of i64 with JS BigNum support #34

Open danleh opened 2 years ago

danleh commented 2 years ago

See https://github.com/danleh/wasabi/issues/31#issuecomment-786532720

Copied from there: remove Long.js dependency completely and use JavaScript BigNums instead, see https://github.com/WebAssembly/proposals/blob/master/finished-proposals.md and https://github.com/WebAssembly/JS-BigInt-integration

doehyunbaek commented 11 months ago

I think this commit https://github.com/jakobgetz/wasabi/commit/280947b94db2a19072575f100a9387904661d45d is quite minimal and easy to review. If you don't mind I'll make a pull request cherry picking this commit.

danleh commented 11 months ago

That commit looks great, if you could make a PR out of it and it passes tests, we can merge it as-is.

doehyunbaek commented 4 months ago

I'll work on this in a few weeks. Forgot in a hurry!