danlooo / DGGS.jl

Discrete Global Grid System for Julia
GNU Affero General Public License v3.0
11 stars 2 forks source link

Remove GeoCube #86

Closed danlooo closed 6 months ago

danlooo commented 6 months ago

A GeoCube is just raster data complying to:

There is no additional data being stored compared to a Raster or YAXArray{2}. Thus, let's remove that type and check on construction of the cell cube:

function CellCube(raster::AbstractDimArray; lon_name::Union{Nothing, String}=nothing, lat_name{Nothing, String}=nothing)
    if isnothing(lat_name)
    # search for common axis name e.g. YAXArrays.findAxis()
    end
  end
end

In addition, there is no need for DimensionalData.@dim, e.g. define specific dimensions for Q2DI axes. This info will be also lost during loading the dataset from disk.

danlooo commented 6 months ago

see #88