danluca
commented
3 months ago @marcinsmialek - oh, my goodness!! So, so, sorry for not paying attention to this repo in such a long time 😞 While my initial intent when I started the fork was to come back to the parent Pscx with a PR, my selfish needs have prevailed and my current version has diverged quite a bit from the main Pscx and subsequent updates, both implementation detail and likely scope and strategy.
Publishing to Gallery has crossed my mind but I didn't think much of it - it'd be odd to have two different flavors of the same library in the Gallery. If my fork is valuable, it'd be good to have Pscx maintainers input on whether to merge, cherry pick or create a new product somehow (that inherits quite a bit of their work).
Either way, there is a decent list of things I see as pre-requisites in terms of quality before this flavor can be shared with any hopes of reliability (I, for one, would like to stand by the quality of the artifacts that carry my name 😎 ).
- working & passing tests in the CI/CD (actions), add more tests for a decent coverage
- proper multi-platform functionality of applicable (sub-)modules
- beyond occasional use on current (at the time) macOS, Ubuntu versions I haven't done extensive testing on these *nix platforms
- clean up of code/functionality that is obsoleted, replaced by PowerShell Core mainstream features, or that simply doesn't work anymore
- proper code signing certificate
- up-to-date documentation, changelog, etc.
My two cents...
Can you publish your fork on the PowerShell Gallery?
It looks solid and having it easily available and upgradeable as a PowerShell Gallery Module might be beneficial for the users. I'm afraid the scope of your changes might be too great to be accepted as a PR to the main Pscx/Pscx repo