Added extended xml comments to the FromDouble* methods (WIP)

danm-de / Fractions

A fraction data type to calculate with rational numbers.

BSD 2-Clause "Simplified" License

50 stars 15 forks source link

Closed lipchev closed 6 months ago

lipchev commented 6 months ago

Fraction.ConvertFrom split into Fraction.ConvertFromNumber and Fraction.ConvertFromString (no changes to the code)
replaced the xml comments from the FromDouble* functions (providing details about the possible caveats with each one)
replaced the Readme sections regarding the Creation from double with an extended version (including the new overload)

lipchev commented 6 months ago

oh, did i miss some change in the ConvertFrom, why is this giving me a conflict.. 😕

danm-de commented 6 months ago

Sorry, I do not want to split those files.

lipchev commented 6 months ago

Sure, no problem- I had messed up the branch anyway. I'll create a new one..

danm-de commented 6 months ago

As a non-native English speaker, I think the documentation improvement is great. Unfortunately it's mixed up in this branch.

danm-de commented 6 months ago

Sure, no problem- I had messed up the branch anyway. I'll create a new one..

Cool, thanks!