danm1n / sudoku-webapp

Sudoku With A Difference made with react and nodejs. See where you rank on our global leaderboard. Give it a try!
https://sudoku-webapp.herokuapp.com
1 stars 0 forks source link

if I don't complete the puzzle and submit it its says you won(half filled or unfilled) #5

Closed mushkanT closed 4 years ago

danm1n commented 4 years ago

@mushkantisekar Hi, thanks for giving it a try. Please can you tell me more about the problem, don't seem to have it on my end. Did you run it locally?

mushkanT commented 4 years ago

ah sorry i tried your link given in the description if i submit it half filled it says you won.

danm1n commented 4 years ago

@mushkantisekar Ok, i see. I'm getting this issue on Firefox only and will address it.. Can you confirm with me what browser you are using. I get no issues on chrome itself.

mushkanT commented 4 years ago

"You won, well done!" this is what i get i tried it on microsoft edge as well as chrome on my laptop got the issue on both the browsers though for me . haha i would like to upload a screenshot of the issue but i am new to github i dont know how to do it by the way can you give the json file of your database ?

danm1n commented 4 years ago

@mushkantisekar Ok actually it was issue on my browser : ), i took a look at the code, was a problem in my api with a logical operator. Just had to make sure validgame === true as validgame as three responses 'clash', false and true, didn't take into account that 'clash' the string is also true. https://github.com/incrediblejagur/suduko-webapp/blob/4a46bfc9fdcbd69b4281f06ccb5921024f759c81/api/sudoku_api.js#L34 Thanks for that, i noticed a few minor bugs will try to fix them in my free time.

mushkanT commented 4 years ago

could you give your json file of your database you used for this app? Thanks He gave : {"title":"Sudoku Webapp","values":[["dyllan","dyllanhope",1,null,null],["test","test",0,null,false],["daniel","daniel",2,null,null],["mughals","mughals",0,null,null],["Ben","ben123",0,null,null],["Jake","jake42",0,null,null],["Mkt","Mkt",50,null,false],["Andre","andre",2,null,null],["Daniel","incrdiblejagur",0,null,null],["makho","makho20",0,null,null],["mkt","alex",53,2,false],["incrediblejagur","incrediblejagur",48,10,null],["Sino","silkchocolate",0,5,false],["Thabang","gideon877",2,null,null],["Mark","Mark",0,null,false],["Martin","Martin",12,2,false]],"fields":["name","username","highscore","level","admin"],"types":[25,25,23,23,16],"type_names":["text","text","integer","integer","boolean"],"started_at":"2020-06-24 12:03:21 +0000","finished_at":"2020-06-24 12:03:22 +0000","checksum":"f441492f88b7cbe84b1004768a85cce5"}

danm1n commented 4 years ago

Here's an export of my heroku dataclip. https://raw.githubusercontent.com/incrediblejagur/suduko-webapp/master/dataclip.json