search

danm36 / zen-browser-private-browsing-toolbar-highlighting

Zen Browser theme that adds extra styles to windows in private browsing mode to more clearly indicate the mode.
MIT License
3 stars 0 forks source link

The interface is buggy!! #7

Open nanoraptor opened 2 days ago

nanoraptor commented 2 days ago

temptemp

image

As you can see the private browsing icon is not positioned correctly. Also If I switch the highlight style from gradient to solid, it overflows from the title bar to the sidebar as you can see in the image 2.

Most of all there is no "Private mode" Indication above the sidebar.

*Note: I checked in both light and dark modes, the issue still persists. I use the latest version of zen - (1.0.1-a.8 (64-bit) (Generic/Non-Portable) (Windows 10)

nanoraptor commented 2 days ago

For additional context, I have my workspace button there. But even after relocating it, nothing changed.

image

danm36 commented 1 day ago

Hi, thanks for the report! Are you using the Mac version of Zen? The user profile icon is in a completely different place for me, being located just above the sidebar, and the incognito icon is anchored to that. Zen Mods can't insert new elements, so unfortunately I need an existing element to append something too, and - at least in the case of the Windows version of Zen - the user icon was the most appropiate.

image

As far as I'm aware, the Private Mode text indicator on the sidebar was only added natively for a short while before being hidden again, and that wasn't something that I ever touched as it was removed before I had time to update this mod (Again, in the Windows version. I'm not sure if it was around for longer on the Mac version?)

I do experience the solid color overflow though - I inadvertently configured it to account for the Bookmark Toolbar Tweaks mod I have installed - and I'll try to get a fix in for that. Unfortunately, the only Mac I have access to is for work and they limit what I can install, so I'm not sure if I can resolve the other issues. I'll see if I can work something out.

nanoraptor commented 1 day ago

*Note: I checked in both light and dark modes, the issue still persists. I use the latest version of zen - (1.0.1-a.8 (64-bit) (Generic/Non-Portable) (Windows 10)

I use Windows 10

nanoraptor commented 1 day ago

When I place the user icon at the right end of the title bar. Weird stuff happens. If I place it on icon before the last icon. I get the issue as I stated above. If I place it at the very last, then the PB icon replaces the three dots. image

image

image image

I think the last two cases can be handled differently. By placing the icon in the left extremite of icons.

danm36 commented 1 day ago

Thanks for the info. I'm going to be honest, I had no idea you could move the toolbar icons like that, so you've given me some more insight into Firefox despite having used it for a decade now 😄. That's also why I thought you might have been using MacOS - I didn't recognize the home or library icons, and thought that was something MacOS itself had added.

I'll try to puzzle out a new solution for icon placement, probably something that could be configured in the mod settings to suit everyone's toolbar icon positions.