danmaclean / gee_fu

An extensible Ruby on Rails web-service application and database for visualising HTGS data
18 stars 5 forks source link

Review tools #26

Closed mrship closed 11 years ago

mrship commented 11 years ago

@danmaclean This PR makes /tools require a user login and fixes the HTML so the extract sequence form submits.

However, it doesn't appear to work, failing with undefined method 'name' for nil:NilClass. I notice that it fails in the same way in the original app as well though, so can you advise on what's needed for a valid extraction?

danmaclean commented 11 years ago

Made an error when updating this. Bad parameter accessed on params hash, Line 13 tools_controller.rb should read

ref = Reference.find(:first, :conditions => {:name => params[:reference] , :genome_id => params[:genome_id] } )

(this train has dodgy wi-fi so wont risk pulling the whole thing for a one line fix! )