search

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js
Other
1.97k stars 192 forks source link

removed resanitize and bumped the version on iconv to latest #134

Closed designfrontier closed 9 years ago

designfrontier commented 9 years ago

Removed resanitizer as a dependency since the only thing in use was a 4 line function. Moved the function to utils. This was because there is a known vulnerability in one of resanitzer's dependencies ( isUrl and filter bypass ) that require a pretty substantial rework.

feedparser only uses the stripHtml function from resanitizer which is tiny (4 lines of code) and not effected by the vulnerabilities. So I pulled those out and put them in the utils.js file.

Also bumped iconv to latest because the version in the package.json didn't like node 0.12.

All tests passing and should be ready to rock and roll.

designfrontier commented 9 years ago

Test failures are with node 0.8 seems to be an issue with assert-plus being incompatible with 0.8

danmactough commented 9 years ago

Thanks @designfrontier! I'm going to merge this and actually remove 0.8 support before I publish.

designfrontier commented 9 years ago

@danmactough No problem :-)