Prefer atom link elements with type=text/html

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js

Other

1.97k stars 192 forks source link

Prefer atom link elements with type=text/html #146

Closed andris9 closed 9 years ago

andris9 commented 9 years ago

This is related to #144 and #145. The current behavior accepts link elements with invalid type, for example if the feed includes the following items, then rel=self is used even though its type is application/atom+xml

<link rel='self' type='application/atom+xml' href='feed-item-url'/>
<link rel='alternate' type='text/html' href='blog-post-url'/>

This PR changes the behavior to prefer elements with type=text/html

danmactough commented 9 years ago

Nice. Thanks, @andris9

danmactough commented 9 years ago

published as v1.1.3

andris9 commented 9 years ago

Thanks!

rdbcci commented 9 years ago

Yes, this problem made feeds.feedburner.com feeds misbehave. Thanks.

danmactough commented 9 years ago

@rdbcci :tada: