search

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js
Other
1.97k stars 192 forks source link

What events should fire off for a bad feed? #194

Closed cdellinger closed 6 years ago

cdellinger commented 7 years ago

This is related to issue #186 (https://github.com/danmactough/node-feedparser/issues/186). It got closed and wasn't sure if anyone was still seeing comments there, sorry if I'm creating more noise by creating this issue, I'm never sure how to handle closed issues in GitHub if questions still remain.

My question is what the behavior should be with the new 2.0.0 version. If I understood your response in #186, if a feed that is badly formed is processed, we should see an errorevent emitted and we should not see an endevent emitted, is that correct?

My question/issue is I see that behavior happening unless there is logic in the readableevent. If code resides in the readableevent, I see both an errorand endevent firing off. Is that behavior expected? Should the errorevent record that some error occurred and the readable event check against this value and not process if that was the case?

danmactough commented 6 years ago

@cdellinger I'm sorry you're feeling confused. I don't have any more guidance or ideas than what I said in #186.

If you can identify a bug, please open a new issue. But there's really nothing I can do here, so I'm going to close this issue.