search

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js
Other
1.97k stars 190 forks source link

added support for itunes iOS 11 podcast changes, including item's new… #230

Closed avimak closed 6 years ago

avimak commented 6 years ago

… season, episode & episodeType fields, and meta's (/channel's) type field.

avimak commented 6 years ago

@danmactough, pls let me know how can I help to push this forward.

danmactough commented 6 years ago

Hi, @avimak. Thanks for your PR! I'm not going to add this, however, since those itunes extensions don't map to any standard RSS properties. The point of those generic properties is to map to the RSS 2.0 spec, so I don't think it's appropriate to add them.

Note that you already have access to all that itunes-specific information (for example, in the meta, you can always access meta['itunes:type']).

scripting commented 6 years ago

I like this approach.

I have been able to access elements that I've added in my "source" namespace this way.

Dave

On Thu, Aug 17, 2017 at 3:16 PM, Dan MacTough notifications@github.com wrote:

Hi, @avimak https://github.com/avimak. Thanks for your PR! I'm not going to add this, however, since those itunes extensions don't map to any standard RSS properties. The point of those generic properties is to map to the RSS 2.0 spec, so I don't think it's appropriate to add them.

Note that you already have access to all that itunes-specific information (for example, in the meta, you can always access meta['itunes:type']).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danmactough/node-feedparser/pull/230#issuecomment-323168070, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm9O1rtBUqg5TqoSosylDqEZIsI3FT6ks5sZJGYgaJpZM4O5ITo .

avimak commented 6 years ago

@danmactough, @scripting, thanks for the comments, and I respect your point of view.

the problem with this approach, as I see it, is that you losing default values in case of missing tags, (e.g. defaults to 'full', defaults to 'episodic', etc.). some podcasts RSS won't have these tags (e.g. they aren't hosted on iTunes) so I thought that persisting these tags with their default values will make life much easier for clients parsing podcasts RSS. as for standards, Apple controls most of this (podcasts) market and usually (+ historically) sets these standards, so once iOS11 is out, we should expect a mass adoption of these tags, which will probably lead to new standards. just something to keep in mind :)