Cannot parse one particular feed: "Cannot read property..."

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js

Other

1.97k stars 192 forks source link

Cannot parse one particular feed: "Cannot read property..." #268

Closed ghost closed 6 years ago

ghost commented 6 years ago

Node-feedparser 1.0.1 (from NPM) feedparser 2.2.9 Node 8.10

EVERY other RSS feed seems to work perfectly with Node-feedparser, but I cannot get this one to work.

https://feeds.feedburner.com/technologypodcastncbi

I've looked at the parsed feed, and I've tried:

let audioData = items.slice(0, 10).map(obj => ({
url: obj.enclosures[0].url
url: obj["media:content"]["@"].url
url: obj["rss:enclosure"]["@"].url

All give me TypeError: Cannot read property 'media:content' of undefined even though I can stringify out the object and it's fine. Weird. Is it something I'm doing wrong? Thanks

Before submitting your issue, please make sure these boxes are checked. Thank you!

[x] Review the compressed example.
[x ] Include which version of FeedParser you're using.
[x] Include which version of Node you're using.
[x] Include a link to any feed you're having a problem with.

rdbcci commented 6 years ago

running this: let audioData = a.map((obj,i) => {if(!obj.enclosures[0])return;console.log('%s i=%s',obj.enclosures[0].url,i)}); on returned items gives:

indicating (at the time I ran it) item with index 4 had no media objects.

You need to verify the objects exist before you try to use them.

ghost commented 6 years ago

Oh, thanks so much! So it's a broken feed, nothing I'm doing wrong? Thanks for the code tip, too!

rdbcci commented 6 years ago

Feeds are very free form. Feedparser only returns what's in the feed. Just because it's supposed to be there doesn't mean it will be.

danmactough commented 6 years ago

Sounds like you're all set @digitaltoast. Thanks @rdbcci!