complicated example using iconv and request, using parsing charset from response header

danmactough / node-feedparser

Robust RSS, Atom, and RDF feed parsing in Node.js

Other

1.97k stars 192 forks source link

Closed kof closed 10 years ago

kof commented 10 years ago

I can change anything you want if you don't like something

danmactough commented 10 years ago

Thanks. Just busy with work. I'll try to take a look over the weekend.

danmactough commented 10 years ago

Closed via 0c40d32.

Made a few changes, fyi. Mainly the following:

Use our own localhost server to serve up the feed -- faster and won't fail if source changes or otherwise fails
Rewrote the main method to make it clearer which handlers belong to which stream. This is a major confusion point for people, so I hope being more explicit in the example clarifies things for people.

Thanks for the PR.