made it possible to create a `TokenList` from a buffer

danmar / simplecpp

C++ preprocessor

BSD Zero Clause License

204 stars 80 forks source link

Closed firewave closed 4 months ago

firewave commented 6 months ago

Still need to integrate/test it with #261 to make sure it does not introduce any issues.

It is already actively used by Macro though and no tests are failing, so it should be fine.

firewave commented 6 months ago

Some tests are still failing - will investigate.

firewave commented 6 months ago

The tests failing are the ones with binary characters in the string. We need to add an additional const char*, int input for those.

firewave commented 6 months ago

I changed it from a std::string input to a const unsigned char*, std::size_t and const char*, std::size_t (for convienience).

The tests pass but it produces valgrind failures in #261.

firewave commented 6 months ago

The tests pass but it produces valgrind failures in #261.

firewave commented 5 months ago

I will provide a downstream PR which shows this is working within Cppcheck.

We should also do the (planned) release before merging this.

danmar commented 4 months ago

@firewave would you like that I release simplecpp now or do you have some more fixes..?

firewave commented 4 months ago

@firewave would you like that I release simplecpp now or do you have some more fixes..?

Do the release so we are in proper sync again.

Afterwards this PR, #339 and #312 require your feedback - and some minor work from my side.

firewave commented 4 months ago

Here is the downstream PR using char buffers instead of streams: https://github.com/danmar/cppcheck/pull/6379.

firewave commented 4 months ago

Ready for review since the downstream PR passes all tests.

danmar commented 4 months ago

@firewave you should have gotten an invite for this project. I hope you can merge..

firewave commented 4 months ago

you should have gotten an invite for this project. I hope you can merge..

@danmar Thanks.