danmarsden / moodle-local_recompletion

Allows course recompletion
29 stars 45 forks source link

User notification fails with php error #151

Closed DavidPruem closed 6 months ago

DavidPruem commented 6 months ago

The plugin successfully resets the course, but no notification email is sent.

OS: Debian Linux PHP: 8.1 Moodle Version: 4.1.8 DB: mariadb

There is a code error message in the task log. It seems the scripts expects a string argument at some point but receives an array.

Execute scheduled task: Prüfen, ob Nutzer Kurs wiederholen müssen (local_recompletion\task\check_recompletion) ... started 00:18:01. Current memory use 20.3 MB. Debugging increased temporarily due to faildelay of 60 ... used 109 dbqueries ... used 1.5371451377869 seconds Scheduled task failed: Prüfen, ob Nutzer Kurs wiederholen müssen (local_recompletion\task\check_recompletion),trim(): Argument #1 ($string) must be of type string, array given Backtrace:

matthewhilton commented 6 months ago

Hi @DavidPruem just FYI I encountered the same error but fixed it by upgrading the plugin version. I was getting the same error on 4becd2c7d37b698161421019a51b626013dfc77a but now on f8d86c888a123fb0bf620b0be9533a1f476e1460 it is fixed.

danmarsden commented 6 months ago

Thanks @matthewhilton - I've also just fixed the plugins db token in this repo and bumped the versions which has published new versions to the plugins db now - but yes, the latest version will always be in github.