danmarsden / moodle-local_recompletion

Allows course recompletion
29 stars 45 forks source link

exposes 'local_recompletion_reset_course' as webservice #186

Closed mariovitale1979 closed 1 month ago

mariovitale1979 commented 1 month ago

local_recompletion_reset_course was added as external service but since it was not declared as a service which is required iin case you want to call this service through a webservice call

danmarsden commented 1 month ago

Hi @mariovitale1979 - your description here doesn't seem to be correct - the service definition in the $services var is optional and only typically used when there are a collection of webservices that you want to preconfigure as available on the "external services" page.

Typically you would hit the "Add" button at the bottom of the admin > server > webservices > external services page - give it a name, then add the specific webservices (like the receompletion one) to that service.

I'm not sure what benefit a custom service that only contains a single webservice call provides?

mariovitale1979 commented 1 month ago

You are right Dan. Thanks for explaining, I will close PR

danmarsden commented 1 month ago

no worries! - feel free to send any other PR's through - great to have other people contributing to the plugin!