search

danmarsden / moodle-local_recompletion

Allows course recompletion
29 stars 45 forks source link

CourseRecompletion in course with multiple LTI Tools #42

Closed gemguardian closed 2 years ago

gemguardian commented 2 years ago

I jumped into an issue with the CourseRecompletion when used in a course with multiple LTI Tools. It did not seem to save data in the local_recompletion_ltia and did not clean the finalgrade in the enrol_lti table.

I have asked @luukverhoeven to take a look at it and he fixed the issue and will send in a push request. It would be great if this could be checked/accepted as soon as possible.

Gemma

danmarsden commented 2 years ago

sounds great - @luukverhoeven the code has gone through a decent restructure now - the bulk of the lti work is now in here: https://github.com/danmarsden/moodle-local_recompletion/blob/MOODLE_311_STABLE/classes/activities/lti.php

luukverhoeven commented 2 years ago

@danmarsden Thanks, I noticed the restructure, nice work! Just created two pull request for MOODLE-39 and MOODLE-311. It goes through all the LTI tools instead of one.

Can you validate the code and approve, if it's ok?

danmarsden commented 2 years ago

Looks good thanks @luukverhoeven - I've merged that in!

gemguardian commented 2 years ago

Thank you @luukverhoeven and @danmarsden .