danmarsden / moodle-mod_attendance

Allows an attendance log to be kept in Moodle
https://moodle.org/plugins/mod_attendance
64 stars 156 forks source link

Group sessions not added to Moodle calendar unless session for all is present #717

Open a-b0wers opened 11 months ago

a-b0wers commented 11 months ago

Moodle 4.0.11 Plugin version 4.0.11 2022083108

Steps to recreate:

  1. Create Attendance module with visible groups
  2. Create group session
  3. Confirm not visible to group members in Calendar
  4. Go back and create session for all
  5. Confirm the group session (and all session) is now visible in calendar
  6. Delete session for all from attendance module
  7. Confirm the group session is missing from the calendar again

Alternative steps:

  1. Add Attendance module with group mode as separate groups
  2. Add a session for a group
  3. Confirm that it's not visible to group members in Calendar
  4. Change group mode to no groups or visible groups
  5. Add a session for all
  6. Confirm the original group session is now visible in the calendar
danmarsden commented 11 months ago

Thanks for the detailed report! - it does sound like a bug - if you have internal development capabilities, feel free to submit a pull request with a suggested fix and I'll take a look - otherwise this might sit here for a while. thanks!

a-b0wers commented 11 months ago

Thanks Dan.
Unfortunately I can't develop - but I was able to replicate the issue in Moodle 4.2.3 with plugin version 2023041800.