danmarsden / moodle-mod_attendance

Allows an attendance log to be kept in Moodle
https://moodle.org/plugins/mod_attendance
64 stars 151 forks source link

Unable to save custom session fields when editing sessions #736

Closed bwalkerl closed 6 months ago

bwalkerl commented 6 months ago

Custom session fields are currently only saved when a new session is added and not when editing an existing session. Clicking "Save changes" shows success but the custom session fields aren't being changed. It appears like save_customfields() is never called here?

Tested on MOODLE_401_STABLE branch.

danmarsden commented 6 months ago

thanks - doesn't look like many people are using custom fields - that's been a bug for a long time... I've just tidied that up and pushed into the 4.1 and higher branches.