search

danmarsden / moodle-mod_dialogue

Dialogue Module for Moodle
27 stars 35 forks source link

Fix #116 description appearing twice in Moodle 4.x #118

Closed namiarj closed 11 months ago

namiarj commented 11 months ago

Fix #116 description appearing twice in Moodle 4.x

danmarsden commented 11 months ago

thanks @namiarj my usual preference is to create a new branch rather than add statements like that, if you would like to create a PR to just remove the extra description print I can create a new branch for 4.1 and higher here and merge it into that instead.

thanks!

namiarj commented 11 months ago

thanks @namiarj my usual preference is to create a new branch rather than add statements like that, if you would like to create a PR to just remove the extra description print I can create a new branch for 4.1 and higher here and merge it into that instead.

thanks!

I agree. It would be cleaner if we drop the line totally for 4.1 and higher. That's what I did in my own setup on 4.2.2. If you create the branch I will do the PR.

danmarsden commented 11 months ago

closing this one off as it's not complete. @lrskinner has a more complete PR in #122 - thanks!