search

danmarsden / moodle-mod_dialogue

Dialogue Module for Moodle
27 stars 36 forks source link

Request: person search to include role assignments/other users #62

Open mnods opened 5 years ago

mnods commented 5 years ago

Hi, we currently have some teaching staff set as assigned roles across a wide range of courses, so not "enrolled" in the course so they don't get included in the person search list. Would it be possible to broaden the parameters for the user listing?

(edited - originally thought that notifications not going out to these roles but it appears that part is ok after some testing.)

Cheers, Mike

troywilliams commented 5 years ago

Hi Mike,

I gather pull request https://github.com/troywilliams/moodle-mod_dialogue/pull/64 releates to this issue?

Cheers,

Troy

mnods commented 5 years ago

Hi Troy, yes it does, I think your code that displays available users with receive capability is specific to "enrolled" users in the course and not role assignments.

Ok to ignore the request as It's probably quite a specific use case we have and the extra code we put in seems to work for what we needed. Not perfect though, I think it does need some tweaking.

On Fri., 1 Mar. 2019, 09:22 Troy Williams, notifications@github.com wrote:

Hi Mike,

I gather pull request #64 https://github.com/troywilliams/moodle-mod_dialogue/pull/64 releates to this issue?

Cheers,

Troy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/troywilliams/moodle-mod_dialogue/issues/62#issuecomment-468504862, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1dDIh4UZBqkIXpdOAav1w83CITXuKMks5vSICAgaJpZM4aQP09 .