search

danmarshall / jscad-now

🧱👀 Instantly view a jscad V2 module while coding
MIT License
22 stars 6 forks source link

Store camera position between reloads #16

Closed danhigham closed 2 years ago

danhigham commented 2 years ago

Hello Dan!

This is persisting the camera position in it's most simple form. I could probably add functionality to clear it in the clean up routine. Or is it best left?!

danmarshall commented 2 years ago

Thanks!! It's been a while, but IIRC the cleanup routine is only on the server side anyways. Perhaps the only issue I could see is if one got themselves into a faraway camera position (like a large model) and then quit, and then started working on a tiny model, which could be invisible from that leftover faraway camera position. Maye we can add a "reset camera" button?

danhigham commented 2 years ago

Sounds good to me! I'm not familiar with nanohtml, can you point me towards any handy guides on the view / controller type setup you have here!

danhigham commented 2 years ago

@danmarshall Actually, don't worry! All done :-)

danmarshall commented 2 years ago

Thanks! Published 1.2.1

danhigham commented 2 years ago

You're very welcome! I forgot to change the README to remove the item from the todo list!

danmarshall commented 2 years ago

Ok, fixed the readme! But I suppose they should just be issues ;) and not in the readme.