fix memory leak by actually letting update finish before starting next update

danmarshall / jscad-now

🧱👀 Instantly view a jscad V2 module while coding

MIT License

22 stars 6 forks source link

fix memory leak by actually letting update finish before starting next update #28

Closed VanGovv closed 3 months ago

VanGovv commented 3 months ago

Hi Dan,

Great tool, really appreciate the work!

I wanted to contribute by fixing the recent memory leak. Hope this helps.

VanGovv commented 3 months ago

Quite certain it is fixed now. The specific delay on setInterval should be parameterized in the future but the 100ms seem to be a good middle ground of performance and resource requirements

danmarshall commented 3 months ago

Hello, thanks for looking at this! Can you re-open the PR?

danmarshall commented 3 months ago

I might be able to re-open...