search

danmayer / coverband

Ruby production code coverage collection and reporting (line of code usage)
https://github.com/danmayer/coverband
MIT License
2.5k stars 161 forks source link

Fix service_test_mode configuration #472

Closed rileyanderson closed 1 year ago

rileyanderson commented 1 year ago

~service_disabled_dev_test_env? should return true if there is no service.~

~We've noticed an influx of Coverband errors in our test suite since this was added. - ERROR -- : Coverband: view_tracker~ ~failed to store, error NoMethodError~

~I believe this check should return true. If there is no service, it can be considered disabled. Is my thinking correct on this?~

Fixes @service_test_mode configuration

danmayer commented 1 year ago

hmm this is more likely that it doesn't have access to a redis in the test environment or test setup. If you have coverband in the test environment and are running it would expect to be able to store things...

If you are talking about something different in terms of "is no service" you mean running coverband outside of a webapp or something without views, could you give me more details?

danmayer commented 1 year ago

Also, in case it helps we generally don't recommend coverband for testing and point folks to simplecov it is more intended for production, staging, and other runtime environments than for running tests, although some folks find it helpful for running selenium style tests to exercise a server.

rileyanderson commented 1 year ago

Ahh ok that makes sense. I guess I had wrongly assumed that it was supposed to be disabled by default in test.

Would you still like this change? I can throw it up another PR if you'd prefer.

danmayer commented 1 year ago

yeah I will take the test mode change if you want to just remove the other change from this PR, thanks

rileyanderson commented 1 year ago

yeah I will take the test mode change if you want to just remove the other change from this PR, thanks

Updated. Thanks for your help!