search

danmed / TasmoBackupV1

Tasmota Backup TasmoBackup - backup all your tasmota devices in one place.
MIT License
130 stars 20 forks source link

wLED backup issues with new wLED version. #73

Open SirGoodenough opened 2 years ago

SirGoodenough commented 2 years ago

I know you have MANY limitations dealing with wLED. Not here to ask for more function. This is what I noticed today as I did a backup of a device with the latest release on it. It appeared to be an issue with the existing code. This is the device that I backed up.

Screenshot_20220922_185313 Screenshot_20220922_190110

The back-up appears to be a success as reported by Tasmobackup.

After it does so, however, the reported version has not changed...

Screenshot_20220922_185541

As long as there is a backup there, it's all good. Just pointing it out as they probably changed some variable on you again.

patrickdk77 commented 2 years ago

Ya, backups are failing. I did test this against 0.13.0-bx and 0.11 and I think 0.12 But testing it again now, using 0.13.1 and 0.13.3, all backups in wled seem to be broken.

If I click backup config or backup presets from the wled settings page, they also fail for me, so it doesn't look like I can fix this.

devzwf commented 1 year ago

i think that fixed i can manually backup config and presets with no issue for the WebUi of wled

but TB still failed (sort of of) saying backup complete but no file in the backup dir.

lensherm commented 1 year ago

Confirming that I can successfully backup config and presets from the WLED GUI on the following versions: 0.13.3 0.13.1 SR fork

Clicking the Backup button on individual WLED devices in TasmoBackup 1.05.00 results in a "Backup completed successfully!" message, yet after this, no backup files are listed for these devices.

patrick-blom commented 1 year ago

Can confirm the same behavior @lensherm described.

patrickdk77 commented 1 year ago

Yes, I need to find time to retest this, for me the wled gui wasn't giving me backups, could have been anything that caused that issue, but it was stopping me from being able to reproduce this correctly, to find the real issue. I won't have time to look into this though till probably thanksgiving. Hope to put out a nice fresh release then fixing a few things.

patrick-blom commented 1 year ago

I found the issue and created a quick fix.

Plz have a look at my PR: https://github.com/danmed/TasmoBackupV1/pull/82

Cheers Patrick