search

danmed / TasmoBackupV1

Tasmota Backup TasmoBackup - backup all your tasmota devices in one place.
MIT License
130 stars 20 forks source link

<Feature Request>The ability to bulk select backups for deletion #74

Open tonyfitzs opened 2 years ago

tonyfitzs commented 2 years ago

Hi, first up. I love this add-on. It has saved me hours in making sure all my Tasmota devices are backed up. But one thing I didn’t realise is that if you don’t set limits on the number of backups, then you will run out of space on your hardware at some point. So to clean up space, it would be really useful to have a purge function that you can clean up all backups that are over x days old AND/OR the capability to bulk select backups and then delete them for each individual device. That way, you can bulk delete and still save backups if you are trying to diagnose a fault or something.

patrickdk77 commented 2 years ago

Why not use the already included options to do this?

Backup Max Days Old to keep Backup Max Count to keep

generally if you don't delete backups, it should take a decades to fill up a storage device, at 4k per backup per device, it will take a very long time to fill up any normal sized device these days, I normally keep 45days of backups personally.

The two values work together, they both must be true, before it will delete a backup, say Max Days is 45 Max Count is 10

Then the backup must be >45days old, and there must be >10 backups of that device, before it will removed.

tonyfitzs commented 2 years ago

Hi Patrick,

Thanks for the reply. As stated in my initial request (although not very clearly I will admit) I only discovered that capability yesterday. And now that it is turned on I have to manually go into each device ( I have a lot of devices) and purge the old unused backups because they don't auto purge once they are captured hence my feature request.

Your suggestion seems to indicate that the excess backups should automatically be removed if I set these two values. However that isn't the case. So perhaps rather than a feature I am now reporting a bug.

Sent from my Galaxy

-------- Original message -------- From: Patrick Domack @.> Date: 5/10/22 3:01 am (GMT+10:00) To: danmed/TasmoBackupV1 @.> Cc: Tony Fitzsimmons @.>, Author @.> Subject: Re: [danmed/TasmoBackupV1] The ability to bulk select backups for deletion (Issue #74)

Why not use the already included options to do this?

Backup Max Days Old to keep Backup Max Count to keep

generally if you don't delete backups, it should take a decades to fill up a storage device, at 4k per backup per device, it will take a very long time to fill up any normal sized device these days, I normally keep 45days of backups personally.

The two values work together, they both must be true, before it will delete a backup, say Max Days is 45 Max Count is 10

Then the backup must be >45days old, and there must be >10 backups of that device, before it will removed.

— Reply to this email directly, view it on GitHubhttps://github.com/danmed/TasmoBackupV1/issues/74#issuecomment-1267228749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIE7PFPCFILAFOGJZSF7H5DWBRIGDANCNFSM6AAAAAAQ4VZDXY. You are receiving this because you authored the thread.Message ID: @.***>

patrickdk77 commented 2 years ago

If this is a bug I am going have to get a lot more information, screen shots of how many backups you have on devices, the settings you have configured.

The prune job is not run till after a new backup has been created for that device, so if you just set those settings, nothing will happen till the next backup is taken.

What do you mean by once they are captured though? they have to be captured long ago for backups to be created.

tonyfitzs commented 2 years ago

Ok thanks Patrick.

If that's the case. Let me see what happens after the next backup cycle. I didn't realise that the purge function is triggered this way. Perhaps I'm just wasting time by writing. Let's wait and see.

I will report back with the information you requested if the issue is not resolved after the backup cycle

Sent from my Galaxy

-------- Original message -------- From: Patrick Domack @.> Date: 5/10/22 10:02 am (GMT+10:00) To: danmed/TasmoBackupV1 @.> Cc: Tony Fitzsimmons @.>, Author @.> Subject: Re: [danmed/TasmoBackupV1] The ability to bulk select backups for deletion (Issue #74)

If this is a bug I am going have to get a lot more information, screen shots of how many backups you have on devices, the settings you have configured.

The prune job is not run till after a new backup has been created for that device, so if you just set those settings, nothing will happen till the next backup is taken.

What do you mean by once they are captured though? they have to be captured long ago for backups to be created.

— Reply to this email directly, view it on GitHubhttps://github.com/danmed/TasmoBackupV1/issues/74#issuecomment-1267697060, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIE7PFNIWRT2BBAPNJ3FV73WBSZQFANCNFSM6AAAAAAQ4VZDXY. You are receiving this because you authored the thread.Message ID: @.***>