search

danmunn / redmine_dmsf

Fork of svn repository for redmine_dmsf
GNU General Public License v2.0
413 stars 193 forks source link

After file convert view permissions missing #1454

Closed Rocksau80 closed 1 year ago

Rocksau80 commented 1 year ago

After converting the documents to DMSF all folders are missing the permissions. I have to change permissions for every folder in a project so that users can see the files. Is there a rake task for that? Or did I miss something during conversion? Folders are showed as created by anonymous while the files are showed as created by uploader. But the checkboxes for the permission groups are empty for every folder.

picman commented 1 year ago
  1. Folder permissions is an extension. They are empty as default. Access to folders is driven by rights to the project. If you want to limit access to a certain folder, you can specify it with the folder permissions.
  2. Each file can have different author. Who should be then the author of the folder?
Rocksau80 commented 1 year ago

Thank you very much for your efforts. I tried the workflow again during the weekend with the same result. I used rake redmine:dmsf_convert_documents issues=1 dry_run=1 RAILS_ENV="production" and it went through without any errors. But the documents were already converted even if I set dry_run=1. After that only for my administrator account the files were visible. All other users couldn't see any file no matter which privilege they had for DMS. I also found something in the wiki: here it says the syntax is dry=true but here in point 11 it says dry_run=1.

Rocksau80 commented 1 year ago

I went through it step by step to see where it fails. So now I did the upgrade vom 3.0.12 to 3.0.13-devel without any further steps. And now permission to see folders and documents in these folders is completely missing for normal users. So files uploaded in the very level of a project are visible to users but not the folders and the documents in there. That's what the administrator user sees: image What normal users see: image These are the permissions set: image

picman commented 1 year ago

I've fixed several problems there. It should work now. Concerning dry_run, it doesn't matter what is there. It checks whether it is empty.

Rocksau80 commented 1 year ago

Looks very promising right now. Files are converted and accessible for the users. I'm doing some more tests here.

Rocksau80 commented 1 year ago

Everything looks good now. There is one problem left and I don't know where I should seek support for that: I ran the convert rake task and the files module is disabled. image But users still see the upload field for files image Act as attachable is set to files & DMS but if we use the lower upload area the files end up in the deactivated files module. If I run the convert job after upload the file is moved to DMSF structure.

picman commented 1 year ago

Files attached to issues are independent on Files module. I think that in Redmine is no such option to disable attachments for issues. Maybe we could extend the pick list to serve third option "Documents only" and hide the Files upload area then.

Rocksau80 commented 1 year ago

I guess I'll open a discussion and/or ticket on the Redmine page about that. It's a bit confusing that if I disable the files and the documents module users still are able to upload stuff. Normally I would disable files for a reason - at the moment because there is a way better option to handle files called DMSF. I opened a ticket at Redmine https://www.redmine.org/issues/38682